Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ceres raw pointers in NameUpdate and delegation signatures #1922

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Dec 12, 2023

based on aeternity/aeternity#4056
found issues aeternity/protocol#521
closes #1811

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk added this to the v13.3.0 milestone Dec 12, 2023
@davidyuk davidyuk force-pushed the feature/raw-pointer branch from b8087d8 to 9015a2f Compare December 12, 2023 06:31
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (00a6c34) 80.05% compared to head (33616db) 80.10%.
Report is 4 commits behind head on develop.

Files Patch % Lines
src/tx/builder/field-types/pointers2.ts 82.75% 1 Missing and 4 partials ⚠️
src/aens.ts 80.00% 1 Missing and 1 partial ⚠️
src/tx/builder/schema.ts 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1922      +/-   ##
===========================================
+ Coverage    80.05%   80.10%   +0.05%     
===========================================
  Files          100      101       +1     
  Lines         3514     3554      +40     
  Branches       719      729      +10     
===========================================
+ Hits          2813     2847      +34     
- Misses         360      362       +2     
- Partials       341      345       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuk davidyuk force-pushed the feature/raw-pointer branch from 39a79a5 to 8382725 Compare January 25, 2024 09:35
@davidyuk davidyuk force-pushed the feature/raw-pointer branch from 8382725 to 33616db Compare January 31, 2024 04:33
@davidyuk davidyuk merged commit 71da12b into develop Jan 31, 2024
5 checks passed
@davidyuk davidyuk deleted the feature/raw-pointer branch January 31, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support raw data pointers to AENS
2 participants